Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Add library item storage APIs #3442

Merged
merged 1 commit into from
May 20, 2024

Conversation

dilyar85
Copy link
Member

Description

This PR adds a new set of APIs to retrieve library item storage, as defined in https://developer.broadcom.com/xapis/vsphere-automation-api/v8.0U1/content/library/item-storage/

Closes: N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Consumed this API in an operator running in the internal Supervisor cluster and verified the expected Storage URI retrieved for each file available in a content library item:

fileInfo:
  - cached: true
    name: ubuntu-20.04-vmservice-v1alpha1.20210528.ovf
    sizeInBytes: "10552"
    storageURI: ds:///vmfs/volumes/... <redacted>
    version: "1"
  - cached: true
    name: ubuntu-20.04-vmservice-v1alpha1.20210528-disk1.vmdk
    sizeInBytes: "1426063360"
    storageURI: ds:///vmfs/volumes/... <redacted>
    version: "1"

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • (N/A) I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dilyar85 , lgtm, just need the 1 fixup for reviewdog

vapi/library/library_item_storage.go Outdated Show resolved Hide resolved
@dilyar85 dilyar85 force-pushed the feature/library-item-storage-api branch from 3796269 to bad6096 Compare May 17, 2024 23:51
@dilyar85 dilyar85 changed the title feat: Add library item storage APIs api: Add library item storage APIs May 17, 2024
@dilyar85 dilyar85 force-pushed the feature/library-item-storage-api branch from bad6096 to ca631f7 Compare May 17, 2024 23:52
@dilyar85 dilyar85 force-pushed the feature/library-item-storage-api branch from ca631f7 to a68c21f Compare May 17, 2024 23:53
@dilyar85 dilyar85 merged commit e172af4 into vmware:main May 20, 2024
10 checks passed
@dilyar85 dilyar85 deleted the feature/library-item-storage-api branch May 20, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants